-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v.1.4.1 #154
Merged
Release v.1.4.1 #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the message store
… KB before new knowledge is added there
This commit removes the outdated question matching approach from 2016. Methods to compare input have been improved since then and can be found in mdr_speech_matching. Further also the content of the README.md file has been removed. Once the new speech recognition and speech processing is set, this needs to be updated.
Remove outdated question matching approach.
…l needs some polishing though)
…t and call the correspondent action
Mbot interface implementation
…subclasses of a class
…t Python package and modified most of the implementations there
remove old plane perceive package
The dependencies were substituted by * mas_perception_libs * mas_perception_msgs Related PR: #149
Change dependency from mas_navigation to mas_navigation_tools
Refactor the perception dependencies
[travis] Add sonarcloud addon
argenos
requested review from
alex-mitrevski,
minhnh and
PatrickNa
as code owners
May 23, 2019 13:35
argenos
added
Type: Enhancement
New feature or request
Type: Maintenance
Changes due to version updates or CI setup
labels
May 23, 2019
minhnh
previously requested changes
May 23, 2019
.../mdr_actions/mdr_manipulation_actions/mdr_move_arm_action/ros/src/mdr_move_arm_action/dmp.py
Show resolved
Hide resolved
mdr_planning/mdr_actions/mdr_manipulation_actions/mdr_pickup_action/ros/scripts/pickup_client
Show resolved
Hide resolved
...ns/mdr_navigation_actions/mdr_move_base_action/ros/src/mdr_move_base_action/action_states.py
Show resolved
Hide resolved
...dr_perception_actions/mdr_gender_recognition/ros/src/mdr_gender_recognition/action_states.py
Show resolved
Hide resolved
...dr_perception_actions/mdr_gender_recognition/ros/src/mdr_gender_recognition/action_states.py
Show resolved
Hide resolved
argenos
dismissed
minhnh’s stale review
May 23, 2019 17:22
Changes are being addressed in #145 or require their own issue
FYI, I've updated the PR description so that it describes the changes more accurately and extensively. |
Sounds good! LGTM! |
PatrickNa
approved these changes
May 24, 2019
minhnh
approved these changes
May 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Type: Enhancement
New feature or request
Type: Maintenance
Changes due to version updates or CI setup
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few reasons to make this PR:
I'm not sure why Travis is not catching some of these errors when we make the PRs, but I've opened #153 for that.
Changes
Architecture
mdr_behaviours
metapackage has been (re)introduced so that scenario states can be easily reused. All existing scenarios have been modified to make use of the behavioursfind_object
action has been added to illustrate the interaction with the ontology and knowledge baseEvent
monitoring message has been added for the purpose of data annotationHRI
RoboCup scenarios
Refactoring
mdr_door_status
from mas_perception Refactor the perception dependencies #149Related PRs and Issues
This PR closes b-it-bots/mas_perception#37